Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(modal): fix modal content padding for regular size #5046

Merged
merged 3 commits into from
Jan 16, 2020
Merged

fix(modal): fix modal content padding for regular size #5046

merged 3 commits into from
Jan 16, 2020

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented Jan 15, 2020

Fixes #4790.

Changelog

Changed

  • A change to ensure "with form" style wins for regular style, for regular size.

Testing / Reviewing

Testing should make sure modal is not broken.

@asudoh asudoh requested a review from a team as a code owner January 15, 2020 05:37
@asudoh asudoh mentioned this pull request Jan 15, 2020
Closed
@netlify
Copy link

netlify bot commented Jan 15, 2020 •
edited
Loading

Deploy preview for the-carbon-components ready!

Built with commit 49dd7a1

https://deploy-preview-5046--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 15, 2020 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit 49dd7a1

https://deploy-preview-5046--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Jan 15, 2020 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built with commit 49dd7a1

https://deploy-preview-5046--carbon-components-react.netlify.com

abbeyhrt
abbeyhrt approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@abbeyhrt abbeyhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

aagonzales
aagonzales approved these changes Jan 15, 2020
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@asudoh asudoh merged commit c890831 into carbon-design-system:master Jan 16, 2020
@asudoh asudoh deleted the modal-content-size-with-form branch January 16, 2020 00:18
joshblack pushed a commit to joshblack/carbon that referenced this pull request Jan 23, 2020
@asudoh @joshblack
fix(modal): fix modal content padding for regular size (carbon-design…
62453e7 
…-system#5046)

Fixes carbon-design-system#4790.
@joshblack joshblack mentioned this pull request Jan 23, 2020
Closed
@joshblack joshblack mentioned this pull request Jan 31, 2020
Closed
@jz2cao
Copy link

jz2cao commented Feb 3, 2020

@joshblack
which version of carbon-component-react do we expect to see this change?
thanks

@joshblack
Copy link
Contributor

joshblack commented Feb 3, 2020 •
edited
Loading

Hi @jz2cao! 👋 I believe it's in carbon-components@10.9.3

@joshblack joshblack mentioned this pull request Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aagonzales aagonzales aagonzales approved these changes

@abbeyhrt abbeyhrt abbeyhrt approved these changes

@emyarod emyarod Awaiting requested review from emyarod

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[modal] inputs/components should be able to span full width
5 participants
@asudoh @jz2cao @joshblack @aagonzales @abbeyhrt